Bukkit server setup not working

I use windows, and I created a bukkit server exactly how the bukkit wiki showed. (in the windows section). Aldo when my friend tested out the server ip he said it wasn't working, and when I simply put my port forward (25565, obviously) it works. I'm thinking there could be three different problems that may be the cause for this.

1: I don't know how to find my ip.
I went to google and searched up "what is my ip" then it told me "your ip is: ##.###.###.##" I'm not sure if this is the right way to find the server ip because my friend uses a mac and he made a server himself claiming he did it the same way.

2.I didn't insert something inside my server properties.

#Minecraft server properties
#Mon Aug 05 18:37:30 EDT 2013
generator-settings=
allow-nether=true
level-name=world
enable-query=false
allow-flight=false
server-port=25565
level-type=FLAT
enable-rcon=false
force-gamemode=false
level-seed=
server-ip=
max-build-height=256
spawn-npcs=true
white-list=false
spawn-animals=true
texture-pack=
snooper-enabled=true
hardcore=false
online-mode=true
pvp=true
difficulty=2
gamemode=0
max-players=20
spawn-monsters=true
view-distance=10
generate-structures=true
spawn-protection=16
motd=lalalalalalalala

is there anything I forgot above? (by the way I already tried putting my ip inside the "server ip" section.)


3. my friend lied to me.

if everything above is correct and there are no other possible problems then my friend lied to me.