2
So I was working on a simple resource pack last night that replaces Creator (Music Box) with "find her" from Deltarune because I thought it kinda sounded like a Music Disc. I was basically done developing it, but when I tested it, I found out it cuts off early for some reason. Why is this? I even tried adding silence to the end to match the original Music Disc, and it still cut off at the same point. Here's a video of the issue:
18
I make stuff
Mojang hardcoded the music length, meaning you can't change the duration.
It's data-driven, not hardcoded. Meaning, you can edit the length via a data pack.
You can't change it with just a resource pack. -_-
I never said that? I'd advise you to read my previous replies and realize I figured that out after posting the thread.
well what I said is that you can't change it with just a resource pack, and what you said is that you now need a datapack to change it, so we're both technically saying the same thing
The track is probably longer than the original creator track. I don‘t know anything about mc‘s code but there‘s probably a line that cuts off the music at a certain point (end of the creator track)
The length is a data-driven thing now, so you have to use a data pack to fix that. I'll be doing that and actually adding a new Music Disc because I figure "why not?".
you're not alone, we were listening to a custom remix of ward that ended abruptly in our game a while back
Did you list it as a sound that is streamed in sounds.json like the other music tracks?
It was a replacement, and I figured out why it was cutting off, so I'll be doing that and turning it into a new Music Disc via a data pack. Technically, I could just edit the length of the existing Music Disc (or rather, jukebox song) via that same data pack, but if I'm gonna be making a data pack, I might as well go all the way.
The first thing is to know waht version you're working in (particularly with the 1.21. changes [assumes java])
It looks like VLC is showing the ogg as 1m16 [hard to read]— is this correct?
(You don't have the Length column enabled for the window, that would be another thing to check.)
If you swap in a different ogg file with a longer length, does this show the same behavior? (This would indicate the issue is with the pack/JSONs rather than the ogg/) [Suggest copying and renaming one of the longer vanilla disk oggs as that would give you a known good ogg file.]
The wiki lists the duration of Creator (Music Box) as 1m13; if this is when your file cuts off, that would suggest the sound event length has not been reset. (Unfortunately, I've not run into tht and am unclear as to where that would be stored or how to reset it.)
Please advise if/when you find a solution, as this would be useful to know
It looks like VLC is showing the ogg as 1m16 [hard to read]— is this correct?
(You don't have the Length column enabled for the window, that would be another thing to check.)
If you swap in a different ogg file with a longer length, does this show the same behavior? (This would indicate the issue is with the pack/JSONs rather than the ogg/) [Suggest copying and renaming one of the longer vanilla disk oggs as that would give you a known good ogg file.]
The wiki lists the duration of Creator (Music Box) as 1m13; if this is when your file cuts off, that would suggest the sound event length has not been reset. (Unfortunately, I've not run into tht and am unclear as to where that would be stored or how to reset it.)
Please advise if/when you find a solution, as this would be useful to know
Crap... well, it looks like the length was the issue, as when I replace cat.ogg with my custom music instead, the track doesn't cut off, but the music note particles continue after the song ends. I guess my best bet is to make this into a data pack to edit Creator (Music Box) or add a new Music Disc and figure out where the Music Disc lengths are stored. Anyway, this is Java Edition 1.21.8, which I've been staying on due to not all of my mods being updated for the latest version.
I actually just found an up-to-date tool on GitHub to add Music Discs for you, but it feels like cheating, especially if I'm going to release this...
I saw the wikim link you embedded in some of the other replies, but would still appreciate the link to the GitHub tool (particularly if it has versions that work with pre 1-21 minecraft)
THX (bookmarked both against possible future need)
