Planet Minecraft using OUTDATED PING

dianneteaWell looking over the code it looks as if it IS a ping method they are using, they just removed the old out of date "hack" for legacy clients, in which case, you are using out of date methods.

I don't really think of Spigot as a third party client, it is Bukkit at its core, just a much much faster Bukkit. Like a Super Bukkit. duh duh duuuh!

16
+@@ -147,7 +152,7 @@ public class PendingConnection extends Connection {
117
+ // CraftBukkit
118
+ org.bukkit.event.server.ServerListPingEvent pingEvent = org.bukkit.craftbukkit.event.CraftEventFactory.callServerListPingEvent(this.server.server, getSocket().getInetAddress(), this.server.getMotd(), playerlist.getPlayerCount(), playerlist.getMaxPlayers());
119
+
120
+- if (packet254getinfo.a == 1) {
121
++ if (true) {
122
+ // CraftBukkit start - fix decompile issues, don't create a list from an array
123
+ Object[] list = new Object[] { 1, 51, this.server.getVersion(), pingEvent.getMotd(), playerlist.getPlayerCount(), pingEvent.getMaxPlayers() };
124
+

Yeah, the problem was that I misunderstood the change. Cyprezz fixed it based on info from a developer that posted on the announcement I made. My apologies for the misunderstanding.

-P

Yay thank you!

I updated it this morning. Try again.

Well looking over the code it looks as if it IS a ping method they are using, they just removed the old out of date "hack" for legacy clients, in which case, you are using out of date methods.

I don't really think of Spigot as a third party client, it is Bukkit at its core, just a much much faster Bukkit. Like a Super Bukkit. duh duh duuuh!

16
+@@ -147,7 +152,7 @@ public class PendingConnection extends Connection {
117
+ // CraftBukkit
118
+ org.bukkit.event.server.ServerListPingEvent pingEvent = org.bukkit.craftbukkit.event.CraftEventFactory.callServerListPingEvent(this.server.server, getSocket().getInetAddress(), this.server.getMotd(), playerlist.getPlayerCount(), playerlist.getMaxPlayers());
119
+
120
+- if (packet254getinfo.a == 1) {
121
++ if (true) {
122
+ // CraftBukkit start - fix decompile issues, don't create a list from an array
123
+ Object[] list = new Object[] { 1, 51, this.server.getVersion(), pingEvent.getMotd(), playerlist.getPlayerCount(), pingEvent.getMaxPlayers() };
124
+

We are using the server ping packet that the protocol describes - we got the implementation details from the (unofficial, but best resource) Minecraft protocol site. This is the only protocol we support:

http://www.wiki.vg/Server_List_Ping

We don't support third party clients (spigot) and their decision to remove a standard which Notchian servers are required to implement. Sorry.

We don't support Query (http://www.wiki.vg/Query) because it is not always enabled and is disabled by default on vanilla & Bukkit servers (last time I checked edit: checked today, enable-query is indeed false by default) - we also feel there is no reason to bother querying two interfaces when one of them is optional.

The only time this will change is if the ping packet is officially deprecated from Minecraft or Bukkit. Until then though, sorry. We're reaching for the masses, not a small group of people who decide for themselves that a standard is no longer required.

-P